-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Er/1607 source paths #4008
Merged
Merged
Er/1607 source paths #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
reviewed
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid first stab! Thanks for throwing up the draft PR so quickly, makes it much easier to see what you're thinking
emmyoop
force-pushed
the
er/1607-source-paths
branch
2 times, most recently
from
October 7, 2021 14:32
063bd9e
to
09f3bc3
Compare
emmyoop
force-pushed
the
er/1607-source-paths
branch
3 times, most recently
from
October 7, 2021 16:40
eeaf08d
to
420141c
Compare
https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working
ypdated tests to use default directory of 'seeds' instead of 'data'
source-paths and data-paths have been deprecated in favor of model-paths and seed-paths. You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it.
emmyoop
force-pushed
the
er/1607-source-paths
branch
from
October 8, 2021 16:41
420141c
to
97473e2
Compare
6 tasks
gshank
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
4 tasks
4 tasks
4 tasks
4 tasks
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* WIP to replace source_path with model_path * updated some test to point to new testing branches https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working * deprecate souce_paths but not remove fully * added deprecation test for path deprecation * replace data-pathswith seed-paths: ['seeds'] ypdated tests to use default directory of 'seeds' instead of 'data' * added test for exception when paths incorectly defined source-paths and data-paths have been deprecated in favor of model-paths and seed-paths. You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it. * fixed test naming issue * fix formatting issues, standardize names * updated branches for dbt-integration-project * updated changelog * synced up rpc deletion messed up when merging * changelog updates automatic commit by git-black, original commits: 0e9a679 bee5bb8
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* WIP to replace source_path with model_path * updated some test to point to new testing branches https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working * deprecate souce_paths but not remove fully * added deprecation test for path deprecation * replace data-pathswith seed-paths: ['seeds'] ypdated tests to use default directory of 'seeds' instead of 'data' * added test for exception when paths incorectly defined source-paths and data-paths have been deprecated in favor of model-paths and seed-paths. You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it. * fixed test naming issue * fix formatting issues, standardize names * updated branches for dbt-integration-project * updated changelog * synced up rpc deletion messed up when merging * changelog updates automatic commit by git-black, original commits: 0e9a679
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* WIP to replace source_path with model_path * updated some test to point to new testing branches https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working * deprecate souce_paths but not remove fully * added deprecation test for path deprecation * replace data-pathswith seed-paths: ['seeds'] ypdated tests to use default directory of 'seeds' instead of 'data' * added test for exception when paths incorectly defined source-paths and data-paths have been deprecated in favor of model-paths and seed-paths. You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it. * fixed test naming issue * fix formatting issues, standardize names * updated branches for dbt-integration-project * updated changelog * synced up rpc deletion messed up when merging * changelog updates automatic commit by git-black, original commits: 0e9a679 1620a17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1607
Description
source-paths
withmodel-paths
data-paths
withseed-paths
, changed default fromdata
toseed
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.