Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Er/1607 source paths #4008

Merged
merged 12 commits into from
Oct 12, 2021
Merged

Er/1607 source paths #4008

merged 12 commits into from
Oct 12, 2021

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 5, 2021

resolves #1607

Description

  • replaced source-paths with model-paths
  • replaced data-paths with seed-paths, changed default from data to seed
  • added explicit deprecation warning
  • update to dbt-integration-project for integration tests.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 5, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid first stab! Thanks for throwing up the draft PR so quickly, makes it much easier to see what you're thinking

core/dbt/config/project.py Outdated Show resolved Hide resolved
core/dbt/config/project.py Outdated Show resolved Hide resolved
@emmyoop emmyoop force-pushed the er/1607-source-paths branch 2 times, most recently from 063bd9e to 09f3bc3 Compare October 7, 2021 14:32
@emmyoop emmyoop marked this pull request as ready for review October 7, 2021 15:37
@emmyoop emmyoop force-pushed the er/1607-source-paths branch 3 times, most recently from eeaf08d to 420141c Compare October 7, 2021 16:40
@emmyoop emmyoop force-pushed the er/1607-source-paths branch from 420141c to 97473e2 Compare October 8, 2021 16:41
@emmyoop emmyoop requested review from gshank and jtcohen6 October 8, 2021 18:33
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emmyoop emmyoop merged commit 0e9a679 into develop Oct 12, 2021
@emmyoop emmyoop deleted the er/1607-source-paths branch October 12, 2021 13:40
@jtcohen6 jtcohen6 mentioned this pull request Oct 13, 2021
4 tasks
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* WIP to replace source_path with model_path

* updated some test to point to new testing branches

https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working

* deprecate souce_paths but not remove fully

* added deprecation test for path deprecation

* replace data-pathswith seed-paths: ['seeds']

ypdated tests to use default directory of 'seeds' instead of 'data'

* added test for exception when paths incorectly defined

source-paths and data-paths have been deprecated in favor of model-paths and seed-paths.  You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it.

* fixed test naming issue

* fix formatting issues, standardize names

* updated branches for dbt-integration-project

* updated changelog

* synced up rpc deletion messed up when merging

* changelog updates

automatic commit by git-black, original commits:
  0e9a679
  bee5bb8
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* WIP to replace source_path with model_path

* updated some test to point to new testing branches

https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working

* deprecate souce_paths but not remove fully

* added deprecation test for path deprecation

* replace data-pathswith seed-paths: ['seeds']

ypdated tests to use default directory of 'seeds' instead of 'data'

* added test for exception when paths incorectly defined

source-paths and data-paths have been deprecated in favor of model-paths and seed-paths.  You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it.

* fixed test naming issue

* fix formatting issues, standardize names

* updated branches for dbt-integration-project

* updated changelog

* synced up rpc deletion messed up when merging

* changelog updates

automatic commit by git-black, original commits:
  0e9a679
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* WIP to replace source_path with model_path

* updated some test to point to new testing branches

https://github.com/dbt-labs/dbt-integration-project needs updates to get all tests working

* deprecate souce_paths but not remove fully

* added deprecation test for path deprecation

* replace data-pathswith seed-paths: ['seeds']

ypdated tests to use default directory of 'seeds' instead of 'data'

* added test for exception when paths incorectly defined

source-paths and data-paths have been deprecated in favor of model-paths and seed-paths.  You can still use the deprecated keys but you cannot define both the deprecated and new keys since we wouldn't know how to handle it.

* fixed test naming issue

* fix formatting issues, standardize names

* updated branches for dbt-integration-project

* updated changelog

* synced up rpc deletion messed up when merging

* changelog updates

automatic commit by git-black, original commits:
  0e9a679
  1620a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an alias for source-paths configuration key
3 participants